Authors: Add four missing authors, mostly selectmenu contributors #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you found them because they showed up earlier, then this PR is incorrect. |
|
No, none of the ones I added were in |
|
My point is that the list is in chronological order, so if you found them because they showed up earlier in the list, adding them to the end of the list is wrong. |
These authors were probably missed during earlier updates due to their commits to the selectmenu branch, were `grunt authors` showed their names above newer authors that contributed directly to master. Also fixed one first name.
|
Gotcha. Updated. |
|
Replaced by #1378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These authors were probably missed during earlier updates due to their commits to the selectmenu branch, were
grunt authorsshowed their names above newer authors that contributed directly to master.I would usually push authors updates directly to master. Though in this case I'd like to point out the limitation of
grunt authors. Can we avoid this problem in the future?Btw. I found the missing names by sorting both
AUTHORS.txtand the output ofgrunt authorsalphabetically, then diffing them. Ignore removed lines, pay attention to added lines.