Button classes

[arschmitz]

Replaced by gh-1513

---

Updates the previous button pr #1333 to the new _add/_remove/_toggleClass api

Of note is a significant re-thinking and simplification of the logic in controlgroup.

[jzaefferer]

Typo, "filter" should be "filter". Also drop the "a" at the end.

[jzaefferer]

Leftovers from #1333:

• demos/controlgroup/splitbutton.html still doesn't use the select option. Add a select event handler that also alerts something.
• Can checkboxradio also support a "CSS only" mode?
• radioGroup definition, commented there

There are some more comments, most of them resolved, except for the discussion about selectmenu width:

It seems like there should be a way to completely stop the selectmenu from setting a width for cases like this where you want it to fill a containers width. /cc @fnagel

[jzaefferer]

Bad markup, delete the p> at the end of the line

[arschmitz]

@jzaefferer

demos/controlgroup/splitbutton.html still doesn't use the select option. Add a select event handler that also alerts something.

Yes it does that was fixed in #1333 and here see https://github.com/jquery/jquery-ui/pull/1333/files#r22649864

Can checkboxradio also support a "CSS only" mode?

Not with our browser support its not possible

radioGroup definition, commented there

Pushed commit already arschmitz@9afd80b

[jzaefferer]

"Button with icon on the bottom", to make it consistent with the text above

[jzaefferer]

Yes it does that was fixed in #1333 and here see https://github.com/jquery/jquery-ui/pull/1333/files#r22649864

Okay, I misread the code. Using "change" seems fine, but why the separate handler instead of using the change option?

Also replacing the alert with appending some text to the page would be good.

[jzaefferer]

Why is this mixing "input inside label" with other variants? Doesn't belong in a demo.

[arschmitz]

@jzaefferer regarding the layout issues in the demos looks like this happened when i rebased with master and the demo font size changed ill go through them all and check the layouts

[jzaefferer]

Should convert this to the change option as part of the .selectmenu() call.