All: Drop support for jQuery 1.6.x #1422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects core, effects, position and widget. Only position has unit tests that fail with jQuery 1.6 without the workaround. Drops the 1.6.x copies jQuery of jQuery and removes them from the select in the testsuites. Fixes #10723
|
I suppose |
|
LGTM |
|
@mikesherov i have an old branch im going to update and submit that removes our dependency on the event alias core module might make sense to do it at the same time. Since now in all supported versions bind is an event alias? |
|
👍 |
|
There are support comments in tests too. |
|
Added a commit that updates core and tooltip tests. Verified both suites tests pass everywhere using browserstack-runner locally. |
|
Looks good. |
|
Landed. @mikesherov @arschmitz yeah, updating bind/on should be done elsewhere. There's currently no ticket (for 1.12) for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects core, effects, position and widget. Only position has unit tests that fail with jQuery 1.6 without the workaround.
Drops the 1.6.x copies jQuery of jQuery and removes them from the select in the testsuites.
Fixes #10723