Selectmenu: Better handling when there are no options #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for not opening when no options this is what native does. |
| @@ -199,7 +202,8 @@ return $.widget( "ui.selectmenu", { | |||
| this._refreshMenu(); | |||
| this.buttonItem.replaceWith( | |||
| this.buttonItem = this._renderButtonItem( | |||
| this._getSelectedItem().data( "ui-selectmenu-item" ) | |||
| // Fall back to an empty object in case there are no options | |||
There was a problem hiding this comment.
Missing blank line above comment
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10662
This replaces #1370.
I think this is a better way to handle empty lists in general. The fact that we were relying on
this.menuItemsas a flag for the delayed rendering has always bothered me. This also includes a change that stops the menu from opening when there are no options.