1 8 stable : Ticket #7084 - Draggable with parent containment and margin#143
Closed
ghusse wants to merge 1 commit into
Closed
1 8 stable : Ticket #7084 - Draggable with parent containment and margin#143ghusse wants to merge 1 commit into
ghusse wants to merge 1 commit into
Conversation
…of the draggable element. Fixed #7084 - Draggable with parent containment and margin
Member
|
Thanks for your patch, but the problem is that it's not taking the right margin into account, doubling the left margin isn't a valid fix. |
Contributor
Author
|
I agree with that, I just adjusted my correction with the current (stable) code. |
Member
|
Thanks, can you send a pull request with your updated patch? |
Contributor
Author
|
Updated with the right/bottom margin ? Yep |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 2 div elements, the parent has a fixed width (600px), the child element with a smaller width value. Both parent and child have the same height.
The child element has a left and right margin of about 5px, and is made draggable with the following options:
When I dragg the child element on left or right, at the very end, child's magin is ignored on dragging. But once the element is dropped, it is moved according to the margin.
This correction fixes this particular issue about margins.