Calendar: minor fixes #1432
Closed
Calendar: minor fixes #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnagel
referenced
this pull request
in fnagel/jquery-ui
Jan 20, 2015
Add calendar widget by copying and renaming datepicker widget files. Remove datepicker functionality, options and methods from Calendar. Remove calendar functionality, options and methods from Datepicker. Adjust tests due to split and changed specification. Remove duplicated demo files and fix some demos. Simplify calendar generation, use CSS instead of inline styles. Fix destroy method. Make use of uniqueId method. Fix focus highlighting when month is changed. Add version property. Add common unit tests. Fix input keyboard handling.
fnagel
referenced
this pull request
in fnagel/jquery-ui
Jan 20, 2015
Add calendar widget by copying and renaming datepicker widget files. Remove datepicker functionality, options and methods from Calendar. Remove calendar functionality, options and methods from Datepicker. Adjust tests due to split and changed specification. Remove duplicated demo files and fix some demos. Simplify calendar generation, use CSS instead of inline styles. Fix destroy method. Make use of uniqueId method. Fix focus highlighting when month is changed. Add version property. Add common unit tests. Fix input keyboard handling.
|
I reviewed the individual commits, again no actual testing. Looks good to me. |
66bfbe7 to
2afae49
Compare
|
Needed to change styles for button elements. Added fix for multiple month border style. |
2afae49 to
8c9f7cf
Compare
|
Updated day item generation to use button elements only. |
|
Travis build failed, including calendar issues. |
|
Looks the same as before in Firefox and Chrome, so that's good! |
e21a56d to
2ea46ae
Compare
8c9f7cf to
fe572c7
Compare
|
Fixed broken calendar unit test. |
fe572c7 to
ef1ce3c
Compare
|
Rebased on to rebased datepicker branch. Thanks @scottgonzalez! |
|
@fnagel What's the status of this? Are you waiting for another review from @jzaefferer? |
|
@scottgonzalez Waiting for another review (if needed) by Jörn or yourself. Otherwise this could be merged right away. |
Move calendarOptions variable into datepicker prototype.
3f717ca to
54aec0c
Compare
|
@scottgonzalez Updated as suggested. |
|
Looks good. |
|
@fnagel What's holding this up? |
|
@scottgonzalez Nothing specific, just hardly free time... |
fnagel
added a commit
that referenced
this pull request
Feb 26, 2015
Move calendarOptions variable into datepicker prototype. Ref gh-1432
fnagel
added a commit
that referenced
this pull request
Feb 26, 2015
fnagel
added a commit
that referenced
this pull request
Feb 26, 2015
fnagel
added a commit
that referenced
this pull request
Feb 26, 2015
fnagel
added a commit
that referenced
this pull request
Feb 26, 2015
fnagel
added a commit
that referenced
this pull request
Feb 26, 2015
|
Merged into datepicker branch 2ea46ae...bbe1eff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor items from the wiki todo list.