Skip to content

Add css-dependency-comments based on jQuery Mobile #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add css-dependency-comments based on jQuery Mobile #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ui/accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Displays collapsible content panels for presenting information in a limited amount of space.
//>>docs: http://api.jqueryui.com/accordion/
//>>demos: http://jqueryui.com/accordion/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/accordion.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Lists suggested words as the user is typing.
//>>docs: http://api.jqueryui.com/autocomplete/
//>>demos: http://jqueryui.com/autocomplete/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/autocomplete.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Enhances a form with themeable buttons.
//>>docs: http://api.jqueryui.com/button/
//>>demos: http://jqueryui.com/button/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/button.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Displays a calendar from an input or inline for selecting dates.
//>>docs: http://api.jqueryui.com/datepicker/
//>>demos: http://jqueryui.com/datepicker/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/datepicker.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Displays customizable dialog windows.
//>>docs: http://api.jqueryui.com/dialog/
//>>demos: http://jqueryui.com/dialog/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/dialog.css
//>>css.theme: ../themes/base/theme.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are CSS dependencies inherited from JS dependencies? In this case, does dialog depend on button.css due to the AMD dependency to button.js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are. In this case, yeap button.css will be included due to the AMD dependency to button.js.


(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
1 change: 1 addition & 0 deletions ui/draggable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//>>description: Enables dragging functionality for any element.
//>>docs: http://api.jqueryui.com/draggable/
//>>demos: http://jqueryui.com/draggable/
//>>css.structure: ../themes/base/draggable.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Creates nestable menus.
//>>docs: http://api.jqueryui.com/menu/
//>>demos: http://jqueryui.com/menu/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/menu.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/progressbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Displays a status indicator for loading state, standard percentage, and other progress indicators.
//>>docs: http://api.jqueryui.com/progressbar/
//>>demos: http://jqueryui.com/progressbar/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/progressbar.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/resizable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Enables resize functionality for any element.
//>>docs: http://api.jqueryui.com/resizable/
//>>demos: http://jqueryui.com/resizable/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/resizable.css
//>>css.theme: ../themes/base/theme.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only interaction that needs the theme, since it uses icons.


(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
1 change: 1 addition & 0 deletions ui/selectable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//>>description: Allows groups of elements to be selected with the mouse.
//>>docs: http://api.jqueryui.com/selectable/
//>>demos: http://jqueryui.com/selectable/
//>>css.structure: ../themes/base/selectable.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/selectmenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Duplicates and extends the functionality of a native HTML select element, allowing it to be customizable in behavior and appearance far beyond the limitations of a native select.
//>>docs: http://api.jqueryui.com/selectmenu/
//>>demos: http://jqueryui.com/selectmenu/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/selectmenu.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Displays a flexible slider with ranges and accessibility via keyboard.
//>>docs: http://api.jqueryui.com/slider/
//>>demos: http://jqueryui.com/slider/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/slider.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
1 change: 1 addition & 0 deletions ui/sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//>>description: Enables items in a list to be sorted using the mouse.
//>>docs: http://api.jqueryui.com/sortable/
//>>demos: http://jqueryui.com/sortable/
//>>css.structure: ../themes/base/sortable.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope of this PR, but would be good to figure out: Both draggable.css and sortable.css are there simpy to define touch-action: none; for handles. We could move this to core.css as a generic class. @tjvantoll @scottgonzalez thoughts?


(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/spinner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Displays buttons to easily input numbers via the keyboard or mouse.
//>>docs: http://api.jqueryui.com/spinner/
//>>demos: http://jqueryui.com/spinner/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/spinner.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing core.css

//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Transforms a set of container elements into a tab structure.
//>>docs: http://api.jqueryui.com/tabs/
//>>demos: http://jqueryui.com/tabs/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/tabs.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down
3 changes: 3 additions & 0 deletions ui/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
//>>description: Shows additional information for any element on hover or focus.
//>>docs: http://api.jqueryui.com/tooltip/
//>>demos: http://jqueryui.com/tooltip/
//>>css.structure: ../themes/base/core.css
//>>css.structure: ../themes/base/tooltip.css
//>>css.theme: ../themes/base/theme.css

(function( factory ) {
if ( typeof define === "function" && define.amd ) {
Expand Down