Skip to content

Dialog: Stop tracking instance in destroy() to avoid memory leaks #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tjvantoll wants to merge 1 commit into from
Closed

Dialog: Stop tracking instance in destroy() to avoid memory leaks #1448

tjvantoll wants to merge 1 commit into from

Conversation

@tjvantoll
Copy link
Member

@tjvantoll tjvantoll commented Feb 18, 2015

Fixes #11125

jzaefferer
jzaefferer reviewed Feb 18, 2015
View reviewed changes
ui/dialog.js Outdated
Copy link
Member

@jzaefferer jzaefferer Feb 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just call ._untrackInstance()?

Copy link
Member Author

@tjvantoll tjvantoll Feb 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like that name better.

Copy link
Member

@scottgonzalez scottgonzalez Feb 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He didn't mean rename it, he meant there's already a function that does this, and it's called _untrackInstance().

Copy link
Member Author

@tjvantoll tjvantoll Feb 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh

Copy link
Member Author

@tjvantoll tjvantoll Feb 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that method works and it's even written nicer than mine. Changed.

@scottgonzalez
Copy link
Member

scottgonzalez commented Feb 19, 2015

I approve of this one line change ;-)

@jzaefferer
Copy link
Member

jzaefferer commented Feb 19, 2015

👍

@tjvantoll tjvantoll closed this in ec1f393 Feb 20, 2015
tjvantoll added a commit that referenced this pull request Mar 10, 2015
@tjvantoll @scottgonzalez
Dialog: Stop tracking instance in destroy() to avoid memory leaks
04ab6e0 
Fixes #11125
Closes gh-1448
(cherry picked from commit ec1f393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjvantoll @scottgonzalez @jzaefferer @jquerybot