Tooltip: Register event handlers before content is loaded #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8740 Closes jquerygh-1053
| } | ||
| }); | ||
| element.trigger( "mouseover" ); | ||
| }); |
There was a problem hiding this comment.
This test was untouched.
|
Thank you for rebasing my changes on the current master! Although I can hardly remember what was actually causing the problem, the changes look fine to me. However, tests are failing not only on Travis but locally as well. Maybe you want to have a look. |
|
Wonderful. The test passes in isolation, but not in the full suite. I'll dig in. |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8740
Closes gh-1053
This replaces gh-1053, which won't apply cleanly because of 8825d93. I've kept @mziech as the author since this is 90% his work. I'd like to get a review from him since it does contain some changes.