Selectmenu: Support width: false and default to 14em
#1467
Conversation
`width: null` still matches the width of the original element. `width: false` prevents an inline style from being set for the width. This makes it easy to set the width via a stylesheet and allows the use of any unit for setting the width, such as the new default of `14em`. Fixes #11198
|
PR for API change: jquery/api.jqueryui.com#255 |
|
Scott: The width property set null matches the width of the original element. The original issue (#11198) is that the default width is insufficient, because the triangle icon take up part of the width. I don't think this fixes #11198. |
Right, so we changed the default. |
|
Ah ha, I didn’t understand that. Thanks!
|
| @@ -210,7 +212,7 @@ return $.widget( "ui.selectmenu", { | |||
| this._getSelectedItem().data( "ui-selectmenu-item" ) || {} | |||
| ) | |||
| ); | |||
| if ( !this.options.width ) { | |||
| if ( this.options.width === null ) { | |||
There was a problem hiding this comment.
Shouldn't this check be consistent with the one above, which uses !== false?
There was a problem hiding this comment.
The check above is inside _create(); the logic is: if we have any size to set, then do so.
This check is inside refresh(). If there is no inline style (false) or there's an explicit width (anything else beside null), then there's no action to take because the state will already be correct. If the value is null and we're copying the size of the original element, then we need to resize the button because that's something external that can change the behavior.
|
👍 |
|
Looks good |
width: nullstill matches the width of the original element.width: falseprevents an inline style from being set for the width. Thismakes it easy to set the width via a stylesheet and allows the use of any
unit for setting the width, such as the new default of
14em.Fixes #11198