Ticket #7092: fix how button label is found#147
Closed
ddstreet wants to merge 5 commits intojquery:masterfrom
Closed
Ticket #7092: fix how button label is found#147ddstreet wants to merge 5 commits intojquery:masterfrom
ddstreet wants to merge 5 commits intojquery:masterfrom
Conversation
…92 - button creation that requires a matching label does not find label in all cases
Member
|
Thanks, can you add a test for this? Also, here's a shorter patch: https://gist.github.com/864880 |
…creation that requires a matching label does not find label in all cases
Contributor
Author
|
That patch works great, and I committed a test case update in my fork: Let me know if you want me to submit a pull request for that test case commit. Thanks! |
Contributor
Author
|
Hmm, I guess I don't understand how pull requests work yet, I didn't mean for my other commits to show up in this pull request, sorry! :-) Anyway, feel free to close this pull request out since you've got a shorter patch for it. Thanks! |
Member
|
Thanks, landed in 0b30a1d. |
tauren
referenced
this pull request
in tauren/jquery-ui
Aug 29, 2011
thg2k
pushed a commit
to thg2k/jquery-ui
that referenced
this pull request
Oct 18, 2011
thg2k
pushed a commit
to thg2k/jquery-ui
that referenced
this pull request
Oct 18, 2011
thg2k
pushed a commit
to thg2k/jquery-ui
that referenced
this pull request
Oct 18, 2011
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finds an associated label even if the checkbox and label do not share a common ancestor.
Really, it would be ideal for jQuery itself to add a function to do this, since this is probably not the only place where something like this is needed...