Slider: Drag selected handle instead of closest#1514
Closed
atomiomi wants to merge 4 commits intojquery:masterfrom
atomiomi:9553-drag-selected-handle
Closed
Slider: Drag selected handle instead of closest#1514atomiomi wants to merge 4 commits intojquery:masterfrom atomiomi:9553-drag-selected-handle
atomiomi wants to merge 4 commits intojquery:masterfrom
atomiomi:9553-drag-selected-handle
Conversation
Drag last changed handle if lastChangedValue is set and target is not a handle Fixes #9553
ui/slider.js
Outdated
Member
There was a problem hiding this comment.
This is a bad name for a property that hold an index instead of a value. Let's rename it.
Correct test and implementation of `_closestHandleIndex` method Fixes #9553
Contributor
Author
|
Current implementation of |
when user clicks on track closest handle changes Refs #9553
change implementation of `_canBeDrag` method Fixes #9553
Member
|
Closing as a stale branch. |
kabalin
added a commit
to kabalin/pastvu
that referenced
this pull request
Dec 8, 2022
- Fixes sliders "stick togeter" issue when user is moving the slider located opposite to the one moved last. - Fixes shifting of sliders by clicking on scale outside sliders. The fix is inspired by PR jquery/jquery-ui#1514 (which has not been merged to jquery-ui) and elaborated further to address click outside sliders as well. Fixes PastVu#532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drag last changed handle if lastChangedValue is set and target is not a handle
Fixes #9553