Include native dialog in appendTo/ui-front logic #1517
Conversation
Even though there's no reason to ever configure the parent element via an `appendTo` option, following the standard logic is useful for scrollable elements and native dialogs. Fixes #10739
|
There should probably be tests for this, or at least a reference to the tickets in the source so we remember why we're treating native dialog elements differently. The code itself looks good to me. |
|
Well, the thing is those comments would be in multiple places and would end up living on for years. Once dialogs become a more common thing, it will just be known that dialogs have crazy stacking logic. |
|
As for documenting why we include |
| @@ -365,7 +365,7 @@ $.widget( "ui.autocomplete", { | |||
| } | |||
|
|
|||
| if ( !element || !element[ 0 ] ) { | |||
| element = this.element.closest( ".ui-front" ); | |||
| element = this.element.closest( ".ui-front,dialog" ); | |||
There was a problem hiding this comment.
Why is there no space after the comma?
There was a problem hiding this comment.
It's a habit that creeps in every once in a while. I blame John for always using no spaces in selectors since they can't be munged by minification tools. Off the top of my head, I was able to think of two places we have selectors with commas and one has spaces and one doesn't :-P
I can add the spaces in; I actually prefer it that way.
There was a problem hiding this comment.
I did a search and found all the selectors that weren't using spaces. Here's a PR: #1521
Apply the same logic to tooltips.
Fixes http://bugs.jqueryui.com/ticket/10739