Skip to content

Selectmenu: Add disabled default options to product selection demo #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fnagel
Copy link
Member

@fnagel fnagel commented Mar 24, 2015

As @jzaefferer proposed, I've added a "please choose" option with selected and disabled attribute.

@jzaefferer
Copy link
Member

Looks good to me. I'll let someone else take a look as well, hopefully we're not on the wrong track.

@fnagel
Copy link
Member Author

fnagel commented Mar 24, 2015

Yeah, not sure if the empty initial state is what we want.

@scottgonzalez
Copy link
Member

What is the intent of this change?

@scottgonzalez
Copy link
Member

@jzaefferer We're wondering why we explicitly want to demo this behavior since it's just standard <select> behavior.

@jzaefferer
Copy link
Member

We didn't have a single demo or even visual test that was using this standard <select> behaviour. I think its worth showing that it still works for selectmenu.

@scottgonzalez
Copy link
Member

Can we find a better demo for it? A product selector that starts with no preview at all isn't great UX.

@tjvantoll
Copy link
Member

Agreed that this is bad UX. What if we just added a fourth select to the main demo with a more common use case for this functionality—maybe salutation?

@scottgonzalez
Copy link
Member

That sounds good to me.

I'll close this and someone can send a new PR with a different change.

@fnagel fnagel deleted the selectmenu-disabled-default branch August 25, 2015 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants