Slider: animation of range and handle in sync

[atomiomi]

use stop() instead of 'queue: false' to begin animation immediatly

Fixes #9459

[tjvantoll]

Hi @atomiomi,

Thanks for taking the time to contribute to jQuery UI. This looks great and I verified that it fixes the issue: http://jsfiddle.net/tj_vantoll/939btayd/1/.

I only have one comment: we try to only use visual tests for things that can't be unit tested, and this seems like something that you could write a test for. Could you try to replace this PR's visual test with a unit test?

Thanks.

[atomiomi]

Hi! Yes, I know about unit testing but I have some doubt with writing test for animation, could you send me an example?

[tjvantoll]

This test from slider's test suite is probably the closest to what you're going to need. You can probably simulate two clicks on the slider, and attach an event handler on the second click to ensure that the previous animation gets completed.

For more generic animation unit test examples, accordion has some pretty good tests, and the effects suite is a pretty good reference as well.

[scottgonzalez]

I don't think we really need a test for this.

[atomiomi]

I've just finished writing unit test that checks synchronicity of max range slider. I tried to run it without changes that were made in the first commit as was expected it failed. Inclusion of patch makes it successful.

[atomiomi]

@scottgonzalez Ooh I could to not write it =) Anyway it's a good experience