Slider: Range fills all space after changing orientation #1533
Conversation
Resets width/height of range
|
For example let's take max range slider. If orientation is changed from horizontal to vertical then the range will fill horizontal space proportionally to value of handle before changing. I reproduced this bug with 1.10 and 1.11 version of jQuery UI in Chrome and Firefox. Test link: http://jsfiddle.net/f52g9u47/4/. To reproduce this bug follow this steps:
It works in min and simple range too. |
|
I didn't create a ticket because of following error: "Maximum number of posts per hour for this IP". I'll create it after a while. |
Reset range's left/bottom position
| @@ -440,7 +440,7 @@ return $.widget( "ui.slider", $.ui.mouse, { | |||
| this._removeClass( "ui-slider-horizontal ui-slider-vertical" ) | |||
| ._addClass( "ui-slider-" + this.orientation ); | |||
| this._refreshValue(); | |||
|
|
|||
| this._refreshRange( value ); | |||
There was a problem hiding this comment.
Please restore this blank line, it's required by our style guide (all comments must be preceded by a blank line).
|
Can you try filing the ticket again? |
|
http://bugs.jqueryui.com/ is unavailable, I'll try later |
|
The server is back up. |
|
For some reason system created two tickets, one of them should be removed: #12205, #12206 (better to remove the second one due to #12205 is specified in the last commit) |
Tests were corrected Fixes #12205
|
I corrected tests. What additional test for height of vertical slider and for width of horizontal slider did you mean? Or I misunderstood you |
|
The range is controlled in two directions. Right now only one dimension is checked per orientation. The test should confirm that both dimensions are adjusted properly. |
|
Ooh I got it, but how for example width of range of horizontal slider should be calculated? My proposition: also specify the slider width then set the value and calculate the range width according to the total width and slider value |
|
Sounds good. |
Wrote additional tests for range dimensions Fixes #12205
|
Tests are done. It's strange that Travis doesn't check the new commit, isn't it? |
|
They're working through some issues: http://www.traviscistatus.com/ |
|
Thanks, this looks good now. |
Resets width/height of range