Tooltip: remove name from live Region #1544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #11272
Member
|
The test is outside of the main closure, but this needs to be rebased anyway since you were working on an outdated branch. |
tests/unit/tooltip/tooltip_core.js
Outdated
Member
There was a problem hiding this comment.
Let's rename to "remove conflicting attributes from live region"
Member
There was a problem hiding this comment.
extraneous space after function
Fixes: #11272
Author
|
Thanks for all the comments scott! :D hopefully I am making all the mistakes so I wont have to later. |
Author
|
OK hopefully with those changes its better, thank you for closing the other pull request, very nice workflow here :D haha |
Member
|
Thanks, squashed and landed with a bit more cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11272