Remove event/alias and deprecated core module dependencies #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a custom build which excludes the event/alias and deprecated modules
| @@ -531,9 +531,9 @@ $.Widget.prototype = { | |||
| eventName = match[ 1 ] + instance.eventNamespace, | |||
| selector = match[ 2 ]; | |||
| if ( selector ) { | |||
| delegateElement.delegate( selector, eventName, handlerProxy ); | |||
| delegateElement.on( eventName, selector, handlerProxy ); | |||
There was a problem hiding this comment.
Do we still need the if and two separate calls?
|
This makes me happy and sad. But the sad part is because of bad design in jQuery. This is good to land. Once the dependencies are updated, I'd like the custom build to become the default version that's used in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds an additional version of jQuery to the tests which excluded the event/alias and deprecated modules.
Note: this does not fully work or pass tests until we also update mousewheel and simulate. The changes in both of these cases are trivial and just a couple lines.