Skip to content

Resizable: Containment works properly when child element has margin#1564

Closed
tswaters wants to merge 1 commit intojquery:masterfrom
tswaters:12980-fixing-resize-margin
Closed

Resizable: Containment works properly when child element has margin#1564
tswaters wants to merge 1 commit intojquery:masterfrom
tswaters:12980-fixing-resize-margin

Conversation

@tswaters
Copy link

@tswaters tswaters commented Jun 3, 2015

Fixes #12980

@scottgonzalez
Copy link
Member

Thanks for your interest in jQuery UI. I'm sorry that the team has been silent for so long. We're in a not-so-great situation where most changes to the interaction plugins, even bug fixes with tests, result in unforeseen regressions. This is our fault for not having good test coverage on the interactions and building complex APIs that cause all kinds of strange behaviors when used together.

We will be rewriting every interaction widget, with some of them already underway. As a result, we will be closing this PR in order to stay with the status quo rather than risk more regressions. At least we know that existing users won't experience new bugs. Again, I apologize for the delay and the lack of review, but we're very grateful for your contribution and hope you will be contributing again.

@tswaters
Copy link
Author

tswaters commented Sep 1, 2016

Where is the work for rewriting interaction widgets being undertaken?

@scottgonzalez
Copy link
Member

Where is the work for rewriting interaction widgets being undertaken?

In the interactions branch.

@tswaters
Copy link
Author

tswaters commented Sep 1, 2016

Would it be beneficial to send a PR against that branch? Can't help but notice the last commit against it was 2 years ago...

@scottgonzalez
Copy link
Member

Would it be beneficial to send a PR against that branch?

Absolutely. If you're interested in helping with the interaction rewrites, we would be happy to go over the plans and figure out a good path forward for you. However, I will say that if your interest is in resizable specifically, that you'll be working from nothing as we have not begun the resizable rewrite yet.

The best method for communication with the team is IRC (see the contributing guidelines for details). But if you're not comfortable with IRC, feel free to just email me.

Can't help but notice the last commit against it was 2 years ago...

That's because the person who was focused on the rewrites hasn't been active for a while and the team's main focus has been elsewhere. You can see what our focus is on our roadmap. You'll notice that our next release (1.13) includes the new interaction base and the draggable rewrite, so these are about to become active again.

@jzaefferer
Copy link
Member

There's also #1611 which isn't quite as old/stale, but also needs helps. Finishing the move to pointer events will benefit all interactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants