Position: Guard against passing window to offset #1565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return { | ||
| element: withinElement, | ||
| isWindow: isWindow, | ||
| isDocument: isDocument, | ||
| offset: withinElement.offset() || { left: 0, top: 0 }, | ||
| offset: hasOffset ? $( element ).offset() || false : false || { left: 0, top: 0 }, |
There was a problem hiding this comment.
What's with the || false? That looks like it guards against the reverted change.
There was a problem hiding this comment.
Also, what's with the false ||?
And why isn't this using withinElement anymore?
|
This needs another review |
|
Reviewed! |
Starting in jQuery 3.0 this will throw an error
|
Fixed last comment |
|
Looks good. |
1 similar comment
|
Looks good. |
|
Merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in jQuery 3.0 this will throw an error