Skip to content

Selectable: proper handling of inner scrolling #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bleshik
Copy link
Contributor

@bleshik bleshik commented Jul 1, 2015

@bleshik bleshik force-pushed the selectable-inner-scrolling-bug branch from 7ed3279 to 1242a71 Compare July 1, 2015 19:21
@bleshik bleshik force-pushed the selectable-inner-scrolling-bug branch 2 times, most recently from 3d5235f to b1e35ac Compare July 2, 2015 05:13
@bleshik bleshik force-pushed the selectable-inner-scrolling-bug branch 2 times, most recently from 4b8d026 to 517582b Compare October 16, 2015 14:17
@bleshik
Copy link
Contributor Author

bleshik commented Oct 16, 2015

It's been 3.5 month since I created the pull request... Could anyone tell me what I should fix in order to have it merged?

@rstepanenko
Copy link

yes, please accept it, we also need it!

@bleshik bleshik force-pushed the selectable-inner-scrolling-bug branch 2 times, most recently from 328d853 to 819511a Compare April 17, 2016 09:46
@bleshik bleshik force-pushed the selectable-inner-scrolling-bug branch from 819511a to caba83b Compare April 17, 2016 09:58
@bleshik
Copy link
Contributor Author

bleshik commented Apr 17, 2016

Another 6 months passed... Resolved the conflicts again, but not sure if I'll keep doing that:)

@jzaefferer
Copy link
Member

We've been avoiding even reviewing this, since most of the logic in interactions is so crazy and fragile, that its very easy to introduce regressions (which are often worse than the original bug). There aren't nearly enough existing tests to compensate for that. I'm not sure how we can get out of that with the very limited resources we've got.

@bleshik
Copy link
Contributor Author

bleshik commented Apr 21, 2016

@jzaefferer, thanks for responding! Got it!
FYI, we've been using jquery-ui with the patch for 9 months with no problems, just saying...:)

@jzaefferer
Copy link
Member

If we were to land this now, release it as part of 1.12.0 and we then get one or more bug reports due to this patch, would you be willing to help us fix those?

@bleshik
Copy link
Contributor Author

bleshik commented Apr 21, 2016

@jzaefferer, sure, just assign those to me and I'll get them fixed.

@jzaefferer
Copy link
Member

Alright, I'll land this then.

@jzaefferer
Copy link
Member

Thank you! Will be released in 1.12.0-rc2 soon.

@bleshik
Copy link
Contributor Author

bleshik commented Apr 22, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants