-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Selectable: proper handling of inner scrolling #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ed3279
to
1242a71
Compare
3d5235f
to
b1e35ac
Compare
4b8d026
to
517582b
Compare
It's been 3.5 month since I created the pull request... Could anyone tell me what I should fix in order to have it merged? |
yes, please accept it, we also need it! |
328d853
to
819511a
Compare
Fixes #13359
819511a
to
caba83b
Compare
Another 6 months passed... Resolved the conflicts again, but not sure if I'll keep doing that:) |
We've been avoiding even reviewing this, since most of the logic in interactions is so crazy and fragile, that its very easy to introduce regressions (which are often worse than the original bug). There aren't nearly enough existing tests to compensate for that. I'm not sure how we can get out of that with the very limited resources we've got. |
@jzaefferer, thanks for responding! Got it! |
If we were to land this now, release it as part of 1.12.0 and we then get one or more bug reports due to this patch, would you be willing to help us fix those? |
@jzaefferer, sure, just assign those to me and I'll get them fixed. |
Alright, I'll land this then. |
Thank you! Will be released in 1.12.0-rc2 soon. |
Thanks! |
Fixes the bug http://bugs.jqueryui.com/ticket/13359