Mouse: Fix delay timeout clearing upon mouseup #1579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b61397d to
14f719b
Compare
|
👍 I really need this fix |
|
Required fix +1 |
|
This really helps in making our UI responsive |
|
We really need it |
|
Good fix! |
| @@ -177,6 +177,10 @@ return $.widget("ui.mouse", { | |||
| this._mouseStop(event); | |||
| } | |||
|
|
|||
| if (this.options.delay && this._mouseDelayTimer) { | |||
There was a problem hiding this comment.
Since this property is never cleared out, the check isn't necessary.
|
That's right @scottgonzalez , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timeout is created when a mousedown is called in ui-mouse, but it is not cleared when a mouseup is fired.
When executing multiple clicks shorter than the duration of the delay, all hell breaks loose, and the functionality of the delay option is unclear.
This fix allows the user to start fresh with a new delay timeout whenever a mousedown is fired.