Skip to content

Mouse: Fix delay timeout clearing upon mouseup #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lsharir
Copy link
Contributor

@lsharir lsharir commented Jul 22, 2015

A timeout is created when a mousedown is called in ui-mouse, but it is not cleared when a mouseup is fired.

When executing multiple clicks shorter than the duration of the delay, all hell breaks loose, and the functionality of the delay option is unclear.

This fix allows the user to start fresh with a new delay timeout whenever a mousedown is fired.

@lsharir lsharir force-pushed the bugfix/ui-mouse-mouseup-timeout-clearing branch from b61397d to 14f719b Compare July 22, 2015 12:59
@NirHemed
Copy link

👍 I really need this fix

@yotmic
Copy link

yotmic commented Jul 23, 2015

Required fix +1

@shaibo
Copy link

shaibo commented Jul 23, 2015

This really helps in making our UI responsive

@royresh
Copy link

royresh commented Jul 23, 2015

We really need it

@eg4000
Copy link

eg4000 commented Jul 24, 2015

Good fix!

@@ -177,6 +177,10 @@ return $.widget("ui.mouse", {
this._mouseStop(event);
}

if (this.options.delay && this._mouseDelayTimer) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this property is never cleared out, the check isn't necessary.

@lsharir
Copy link
Contributor Author

lsharir commented Jul 30, 2015

That's right @scottgonzalez ,
Thank you

scottgonzalez pushed a commit that referenced this pull request Jun 9, 2016
Fixes #14458
Closes gh-1579

(cherry picked from commit 9b82001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants