Skip to content

Fixed date format to correct format. Plays well with jquery globalize. #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jspeaker wants to merge 1 commit into from
Closed

Fixed date format to correct format. Plays well with jquery globalize. #1595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/i18n/datepicker-ko.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ datepicker.regional.ko = {
dayNamesShort: [ "일","월","화","수","목","금","토" ],
dayNamesMin: [ "일","월","화","수","목","금","토" ],
weekHeader: "주",
dateFormat: "yy-mm-dd",
dateFormat: "yy. mm. dd.",
Copy link
Member

@scottgonzalez scottgonzalez Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The month and day should be single digit when possible. I'm not sure which form of the year we would use here. @rxaviers, do we display the medium or short date from CLDR?

Copy link
Member

@rxaviers rxaviers Sep 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @scottgonzalez,

Datepicker rewrite using Globalize 1.x uses {date: 'short'} https://github.com/jquery/jquery-ui/blob/datepicker-globalize-1.x/ui/calendar.js#L42.

For comparison:

Globalize('en').formatDate(new Date(), {date: 'short'})
// > '9/21/15'

Globalize('en').formatDate(new Date(), {date: 'medium'})
// > 'Sep 21, 2015'

Globalize('en').formatDate(new Date(), {date: 'long'})
// > 'September 21, 2015'

Globalize('en').formatDate(new Date(), {date: 'full'})
// > 'Monday, September 21, 2015'

Globalize('en').formatDate(new Date(), {skeleton: 'yMd'})
// > '9/21/2015'

Globalize('en').formatDate(new Date(2015,0,1), {skeleton: 'yMd'})
// > '1/1/2015'

Globalize('en').formatDate(new Date(2015,0,1), {skeleton: 'yMMdd'})
// > Should give you the above using padded months and days when the PR below is complete:
// https://github.com/jquery/globalize/pull/462

Copy link
Member

@fnagel fnagel Sep 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note (from the wiki): "Compared to master, the default date format is different, is that intended? Master has 4 digit years, rewrite only 2"

firstDay: 0,
isRTL: false,
showMonthAfterYear: true,
Expand Down