Skip to content

All: Delegate to base _getCreateOptions(). #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Ensures that any extensions to the base widget will be handled properly by
individual widgets.

Ensures that any extensions to the base widget will be handled properly by
individual widgets.
@jzaefferer
Copy link
Member

Can we extend the common widget tests to make sure all _getCreateOptions overrides call _super?

Otherwise looks good.

@scottgonzalez
Copy link
Member Author

That's tricky because we would need to create an instance of the widget to guarantee that the properties are set to reasonable values for the individual widget's implementation of _getCreateOptions(). Creating an instance requires knowing what markup to use, and widgets like checkboxradio don't have defaultElement set.

We can check for this._super() in the .toString() of ._getCreateOptions(), but it seems a little ghetto.

@jzaefferer
Copy link
Member

I can't think of a non-ghetto approach to deal with this, so lets leave it as it is.

@scottgonzalez scottgonzalez deleted the getcreateoptions branch September 17, 2015 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants