Skip to content

Tooltip: Adds the check to add timers only when both track and… #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Tooltip: Adds the check to add timers only when both track and… #1613

wants to merge 1 commit into from

Conversation

mani-mishra
Copy link
Contributor

As explained in the raised ticket number.
This fix is to add timers only when both track and delay options are present.
The original issue of high CPU usage on mac/chrome when adding timers is a separate concern.

Fixes #14682

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@jzaefferer
Copy link
Member

Looks good to me. That check should've been there in the first place.

@mani-mishra
Copy link
Contributor Author

So should we merge this change ?

@jzaefferer
Copy link
Member

@scottgonzalez are we missing anything?

@jzaefferer jzaefferer changed the title Mani : #14682 : Adds the check to add timers only when both track and… Tooltip: Adds the check to add timers only when both track and… Oct 17, 2015
@jzaefferer
Copy link
Member

Landed with an updated commit message.

scottgonzalez pushed a commit that referenced this pull request Jun 9, 2016
@mani-mishra @scottgonzalez
Tooltip: Use show.delay update only when track option is active
11ebb69 
Fixes #14682
Closes gh-1613

(cherry picked from commit d573232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mani-mishra @jquerybot @jzaefferer