Skip to content

Refactors _updateAlternate() method #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

benjamin-albert
Copy link
Contributor

As far as i'm aware .each(function() { $(this).val( ... ) }); is not required to update the value of all elements in the set of matched element.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@benjamin-albert
Copy link
Contributor Author

I just signed the CLA with my full name Benjamin Albert but github made the commit with the name benjamin-albert (I just updated my profile but I don't know how to amend the commit from the browser).

@scottgonzalez
Copy link
Member

I just updated my profile but I don't know how to amend the commit from the browser

You can't. You'd have to clone the repo locally to amend the commit. But if you're not comfortable doing that, we can fix this when we merge.

As far as i'm aware .each(function() { $(this).val( ... ) }); is not required to update the value of all elements in the set of matched element.
@benjamin-albert
Copy link
Contributor Author

I amended the commit locally.

@scottgonzalez
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants