Skip to content

Tooltip: Remove use of $.parseJSON() #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Also fixes the module loading for the tooltip animations visual test.

Fixes #14903

Also fixes the module loading for the tooltip animations visual test.

Fixes #14903
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @jzaefferer and @rxaviers to be potential reviewers

@rxaviers
Copy link
Member

The JSON update LGTM. I'm unfamiliar on how the data-modules attribute from the script tag is used by the demo.

@scottgonzalez
Copy link
Member Author

I'm unfamiliar on how the data-modules attribute from the script tag is used by the demo.

They're just split on spaces and then injected into a require() call.

@rxaviers
Copy link
Member

They're just split on spaces and then injected into a require() call.

Ok, thanks for the clarification.

@jzaefferer
Copy link
Member

👍

@scottgonzalez scottgonzalez deleted the parsejson branch February 9, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants