Skip to content

Resizable: Implementing setOption for handles #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

kdinev
Copy link
Contributor

@kdinev kdinev commented Jan 21, 2016

The handles could only be changed post initialization, unless the resizable is destroyed and recreated. Related to issues https://bugs.jqueryui.com/ticket/3423 and https://bugs.jqueryui.com/ticket/4310

Fixes: #3423

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@kdinev
Copy link
Contributor Author

kdinev commented Jan 22, 2016

I ran all the tests before I make any changes and there is a datepicker test that fails. I left the test to keep failing after my commit as it's not affected by it.

@scottgonzalez
Copy link
Member

Thanks! The test is a bit awkward, so I'm going to rewrite when I merge this.

@scottgonzalez
Copy link
Member

@kdinev Would you mind looking into https://bugs.jqueryui.com/ticket/15084, which is a regression caused by this change?

@kdinev
Copy link
Contributor Author

kdinev commented Feb 20, 2017

@scottgonzalez I'll take a look at it.

@scottgonzalez
Copy link
Member

Thanks.

@kdinev
Copy link
Contributor Author

kdinev commented Feb 21, 2017

@scottgonzalez I will fix the issue.

One comment however: I don't think the issue should be marked as regressions, as this functionality didn't exist prior to my change. The _setOption could not be performed at all before that, so it's a bug in new functionality, but it's not a regression.

@scottgonzalez
Copy link
Member

That logically makes sense, but somehow this was working before. See https://jsfiddle.net/2cg12b1j/3/ which is the test case from the ticket updated to use 1.11.4. Clicking the button does add the third handle, even though there's no _setOption() defined in resizable. I'm really not sure how that test case works with 1.11.4, but since it does, this seems like a regression.

@kdinev
Copy link
Contributor Author

kdinev commented Feb 21, 2017

Makes sense. Leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants