-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Resizable: Implementing setOption for handles #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
I ran all the tests before I make any changes and there is a datepicker test that fails. I left the test to keep failing after my commit as it's not affected by it. |
Removing the added bower_components to .gitignore
Thanks! The test is a bit awkward, so I'm going to rewrite when I merge this. |
@kdinev Would you mind looking into https://bugs.jqueryui.com/ticket/15084, which is a regression caused by this change? |
@scottgonzalez I'll take a look at it. |
Thanks. |
@scottgonzalez I will fix the issue. One comment however: I don't think the issue should be marked as regressions, as this functionality didn't exist prior to my change. The |
That logically makes sense, but somehow this was working before. See https://jsfiddle.net/2cg12b1j/3/ which is the test case from the ticket updated to use 1.11.4. Clicking the button does add the third handle, even though there's no |
Makes sense. Leave it as is. |
The handles could only be changed post initialization, unless the resizable is destroyed and recreated. Related to issues https://bugs.jqueryui.com/ticket/3423 and https://bugs.jqueryui.com/ticket/4310
Fixes: #3423