Selectmenu: Fixed selectmenu icon float right #1671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the icon space as its not needed with a floated icon Fixes #14914
|
By analyzing the blame information on this pull request, we identified @fnagel, @scottgonzalez and @jzaefferer to be potential reviewers |
|
Looks good. |
| @@ -119,15 +119,12 @@ return $.widget( "ui.selectmenu", [ $.ui.formResetMixin, { | |||
| this._addClass( this.button, "ui-selectmenu-button ui-selectmenu-button-closed", | |||
| "ui-button ui-widget" ); | |||
|
|
|||
| icon = $( "<span>" ).prependTo( this.button ); | |||
| space = $( "<span> </span>" ); | |||
| this._addClass( space, "ui-selectmenu-icon-space" ); | |||
There was a problem hiding this comment.
Looks like this class isn't used anymore. Can you also do a PR for https://github.com/jquery/api.jqueryui.com/blob/1-12/entries/selectmenu.xml#L44 ?
arschmitz
added a commit
to jquery/api.jqueryui.com
that referenced
this pull request
Mar 9, 2016
Ref #14914 Ref jquery/jquery-ui#1671 Closes gh-297
jzaefferer
pushed a commit
to jquery/api.jqueryui.com
that referenced
this pull request
Jul 8, 2016
Ref #14914 Ref jquery/jquery-ui#1671 Closes gh-297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the icon space as its not needed with a floated icon
Fixes #14914