Autocomplete: Work around isContentEditable bug in Chrome

[scottgonzalez]

Fixes #14917

[mention-bot]

By analyzing the blame information on this pull request, we identified @jzaefferer, @arschmitz and @treyhunner to be potential reviewers

[jzaefferer]

What value does editable have in this case? I think this would be easier to understand (assuming its null, replace as needed):

if ( editable === null ) {
  return this._isContentEditable( element.parent() );
}

return editable === "true";

[scottgonzalez]

The third value is "inherit".

Your proposed logic would traverse before checking for an explicitly non-editable element. Traversing always has to be the last operation for inherited values.

[jzaefferer]

This seems fine to me:

if ( editable === "inherit" ) {
  return this._isContentEditable( element.parent() );
}

return editable === "true";

Assuming "true", "false" and "inherit" are the only values editable ever has, that should behave exactly like yours.

[scottgonzalez]

updated