Skip to content

Line length #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arschmitz wants to merge 30 commits into from
Closed

Line length #1690

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6c2e78c
Tabs: Fix line length violations
arschmitz Mar 30, 2016
e1fc956
Spinner: Fix line length violations
arschmitz Mar 30, 2016
d6f13d2
Sortable: Fix line length issues
arschmitz Mar 31, 2016
657831e
Slider: Fix line length issues
arschmitz Mar 31, 2016
fd3c6b8
Selectable: Fix line length issues
arschmitz Mar 31, 2016
fd55b4b
Resizable: Fix line length issues
arschmitz Mar 31, 2016
61870bd
Progressbar: Fix line length issues
arschmitz Mar 31, 2016
54cb50e
Mouse: Fix line length issues
arschmitz Mar 31, 2016
27d7717
Menu: Fix line length issues
arschmitz Mar 31, 2016
9b0783a
Droppable: Fix line length issues
arschmitz Mar 31, 2016
5a0da8e
Draggable: Fix line length issues
arschmitz Mar 31, 2016
804f35a
Dialog: Fix line length issues
arschmitz Mar 31, 2016
2b323d8
Controlgroup: Fix line length issues
arschmitz Mar 31, 2016
d038d51
Checkboxradio: Fix line length issues
arschmitz Mar 31, 2016
c62064b
Accordion: Fix line length issues
arschmitz Mar 31, 2016
76b34ae
Widget: Fix line length issues
arschmitz Mar 31, 2016
041721e
Scroll Parent: Fix line length issues
arschmitz Mar 31, 2016
3bfe871
Position: Fix line length issues
arschmitz Mar 31, 2016
ae9c8fd
i18n: Fix line length issues
arschmitz Mar 31, 2016
c60b20c
Effects: Fix line length issues
arschmitz Mar 31, 2016
787b96e
Build: Fix line length issues
arschmitz Mar 31, 2016
11a95d2
Plugin: Fix line length issues
arschmitz Mar 31, 2016
fb344f1
Effect: Fix line length issues
arschmitz Mar 31, 2016
6cb584c
Selectmenu: Disable maxLineLength for description meta
arschmitz Mar 31, 2016
318905f
Progressbar: Disable maxLineLength for description meta
arschmitz Mar 31, 2016
30b8a1c
Datepicker: Disable maxLineLength for jscs
arschmitz Mar 31, 2016
7ac0cd5
Accordion: Disable maxLineLength for description meta
arschmitz Mar 31, 2016
e53864d
Effects: Disable maxLineLength for description meta explode
arschmitz Mar 31, 2016
da4f90d
Effect: Disable maxLineLength for description meta
arschmitz Mar 31, 2016
07acae9
Build: Remove maxLineLength execption in .jscsrc
arschmitz Mar 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Effect: Fix line length issues
  • Loading branch information
@arschmitz
arschmitz committed Apr 6, 2016
commit fb344f13f5aa26d731aecd09f26d4128d2cfc434
46 changes: 29 additions & 17 deletions ui/effect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ $.effects = {
*/
( function( jQuery, undefined ) {

var stepHooks = "backgroundColor borderBottomColor borderLeftColor borderRightColor borderTopColor color columnRuleColor outlineColor textDecorationColor textEmphasisColor",
var stepHooks = "backgroundColor borderBottomColor borderLeftColor borderRightColor " +
"borderTopColor color columnRuleColor outlineColor textDecorationColor textEmphasisColor",

// Plusequals test for += 100 -= 100
rplusequals = /^([\-+])=\s*(\d+\.?\d*)/,
Expand Down Expand Up @@ -316,7 +317,8 @@ color.fn = jQuery.extend( color.prototype, {
} );

// Everything defined but alpha?
if ( inst[ cache ] && jQuery.inArray( null, inst[ cache ].slice( 0, 3 ) ) < 0 ) {
if ( inst[ cache ] &&
jQuery.inArray( null, inst[ cache ].slice( 0, 3 ) ) < 0 ) {

// Use the default of 1
inst[ cache ][ 3 ] = 1;
Expand Down Expand Up @@ -624,7 +626,8 @@ color.hook = function( hook ) {
var parsed, curElem,
backgroundColor = "";

if ( value !== "transparent" && ( jQuery.type( value ) !== "string" || ( parsed = stringParse( value ) ) ) ) {
if ( value !== "transparent" && ( jQuery.type( value ) !== "string" ||
( parsed = stringParse( value ) ) ) ) {
value = color( parsed || value );
if ( !support.rgba && value._rgba[ 3 ] !== 1 ) {
curElem = hook === "backgroundColor" ? elem.parentNode : elem;
Expand All @@ -650,7 +653,8 @@ color.hook = function( hook ) {
elem.style[ hook ] = value;
} catch ( e ) {

// Wrapped to prevent IE from throwing errors on "invalid" values like 'auto' or 'inherit'
// Wrapped to prevent IE from throwing errors on "invalid" values like
// 'auto' or 'inherit'
}
}
};
Expand Down Expand Up @@ -728,14 +732,16 @@ var classAnimationActions = [ "add", "remove", "toggle" ],
padding: 1
};

$.each( [ "borderLeftStyle", "borderRightStyle", "borderBottomStyle", "borderTopStyle" ], function( _, prop ) {
$.fx.step[ prop ] = function( fx ) {
if ( fx.end !== "none" && !fx.setAttr || fx.pos === 1 && !fx.setAttr ) {
jQuery.style( fx.elem, prop, fx.end );
fx.setAttr = true;
}
};
} );
$.each(
[ "borderLeftStyle", "borderRightStyle", "borderBottomStyle", "borderTopStyle" ],
function( _, prop ) {
$.fx.step[ prop ] = function( fx ) {
if ( fx.end !== "none" && !fx.setAttr || fx.pos === 1 && !fx.setAttr ) {
jQuery.style( fx.elem, prop, fx.end );
fx.setAttr = true;
}
};
} );
Copy link
Copy Markdown
Member

@scottgonzalez scottgonzalez Apr 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the closing paren to the next line.


function getElementStyles( elem ) {
var key, len,
Expand Down Expand Up @@ -1009,7 +1015,9 @@ if ( $.uiBackCompat !== false ) {
$( active ).trigger( "focus" );
}

wrapper = element.parent(); //Hotfix for jQuery 1.4 since some change in wrap() seems to actually lose the reference to the wrapped element
// Hotfix for jQuery 1.4 since some change in wrap() seems to actually
// lose the reference to the wrapped element
wrapper = element.parent();

// Transfer positioning properties to the wrapper
if ( element.css( "position" ) === "static" ) {
Expand Down Expand Up @@ -1198,7 +1206,9 @@ $.extend( $.effects, {

// Convert inline to inline block to account for inline elements
// that turn to inline block based on content (like img)
display: /^(inline|ruby)/.test( element.css( "display" ) ) ? "inline-block" : "block",
display: /^(inline|ruby)/.test( element.css( "display" ) ) ?
"inline-block" :
"block",
visibility: "hidden",

// Margins need to be set to account for margin collapse
Expand Down Expand Up @@ -1490,9 +1500,11 @@ $.fn.extend( {
},

cssClip: function( clipObj ) {
return clipObj ?
this.css( "clip", "rect(" + clipObj.top + "px " + clipObj.right + "px " + clipObj.bottom + "px " + clipObj.left + "px)" ) :
parseClip( this.css( "clip" ), this );
if ( clipObj ) {
return this.css( "clip", "rect(" + clipObj.top + "px " + clipObj.right + "px " +
clipObj.bottom + "px " + clipObj.left + "px)" );
}
return parseClip( this.css( "clip" ), this );
},

transfer: function( options, done ) {
Expand Down