Tooltip: Fix re-enabling of delegated tooltips #1699
Conversation
Fixes #14950
|
By analyzing the blame information on this pull request, we identified @jzaefferer, @mwiencek and @arschmitz to be potential reviewers |
| .removeAttr( "title" ); | ||
| } | ||
| } ); | ||
| this.disabledTitles = this.disabledTitles.add( |
There was a problem hiding this comment.
Why the .add() call (which tends to be rather slow)?
There was a problem hiding this comment.
I wanted to cover .disable().disable() and makes sure the collection wasn't overwritten.
There was a problem hiding this comment.
this.disabledTitles = this.element.find( this.options.items ).addBack() [...] would be simpler/faster, could also skip allocating the empty object.
There was a problem hiding this comment.
That would result in this.disabledTitles being an empty set after .disable().disable() using default settings because this.options.items looks for elements with titles, but the titles are removed after the first call.
Fixes #14950