Checkboxradio: icons inside dialogs #1704
Conversation
|
By analyzing the blame information on this pull request, we identified @arschmitz, @jaspermdegroot and @scottgonzalez to be potential reviewers |
| @@ -134,7 +134,7 @@ a.ui-button:active, | |||
| .ui-widget-content .ui-state-highlight, | |||
| .ui-widget-header .ui-state-highlight { | |||
| border: 1px solid #dad55e/*{borderColorHighlight}*/; | |||
| background: #fffa90/*{bgColorHighlight}*/ /*{bgImgUrlHighlight}*/ /*{bgHighlightXPos}*/ /*{bgHighlightYPos}*/ /*{bgHighlightRepeat}*/; | |||
| background-color: #fffa90/*{bgColorHighlight}*/ /*{bgImgUrlHighlight}*/ /*{bgHighlightXPos}*/ /*{bgHighlightYPos}*/ /*{bgHighlightRepeat}*/; | |||
There was a problem hiding this comment.
Should the comments for unspecified properties be removed? i.e. this line would read
background-color: #fffa90/*{bgColorHighlight}*/;There was a problem hiding this comment.
This change will break ThemeRoller.
There was a problem hiding this comment.
@scottgonzalez how can I test that? Is there a way to make ThemeRoller produce individual properties, rather than consolidated?
There was a problem hiding this comment.
@scottgonzalez how can I test that?
Testing it is a bit tricky. It would require setting up https://github.com/jquery/download.jqueryui.com/ locally and then using your updated theme in ThemeRoller.
Is there a way to make ThemeRoller produce individual properties, rather than consolidated?
You'd have to list all the properties. ThemeRoller just does token replacement. But won't producing individual properties cause the same problem?
Limit a CSS `background` rule that only sets color to `background-color` to avoid losing the `background-position`. Fixes #14955
Limit a CSS
backgroundrule that only sets color tobackground-colorto avoid losing the
background-position.Fixes #14955 (https://bugs.jqueryui.com/ticket/14955)
Also fixed some JS errors in the other checkboxradio visual test; that commit doesn't necessarily satisfy the "avoid unrelated changes" requirement & can be removed if necessary.
Before, then after this change (screenshots from the added visual test):
