Menu: Support number pad keyboard input #1732
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fnagel, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jzaefferer, @apsdehal and @scottgonzalez to be potential reviewers |
|
@arschmitz FYI |
| skip = false; | ||
|
|
||
| // Support number pad values | ||
| character = event.keyCode >= 96 && event.keyCode <= 105 ? | ||
| event.keyCode - 96 : String.fromCharCode( event.keyCode ); |
There was a problem hiding this comment.
I don't think this really matters in this case but when event.keyCode >= 96 && event.keyCode <= 105 we get a number here and when it's less we get a string. Do we want to force character to always be a string for consistency?
There was a problem hiding this comment.
So adding something like ( event.keyCode - 9 ).toString(); would be suitable?
04a168f to
70617f1
Compare
Fixes #15031
70617f1 to
1edd9a1
Compare
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15031