Skip to content

Slider: Add demo for custom handle #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Slider: Add demo for custom handle #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c08b621
Slider: Add demo for custom handle
scottgonzalez Sep 2, 2016
21bf01a
Slider: Apply `tabIndex` to custom handles
scottgonzalez Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions demos/slider/custom-handle.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>jQuery UI Slider - Custom handle</title>
<link rel="stylesheet" href="../../themes/base/all.css">
<link rel="stylesheet" href="../demos.css">
<style>
#custom-handle {
width: 3em;
height: 1.6em;
top: 50%;
margin-top: -.8em;
text-align: center;
line-height: 1.6em;
}
</style>
<script src="../../external/requirejs/require.js"></script>
<script src="../bootstrap.js">
var handle = $( "#custom-handle" );
$( "#slider" ).slider({
create: function() {
handle.text( $( this ).slider( "value" ) );
},
slide: function( event, ui ) {
handle.text( ui.value );
}
});
</script>
</head>
<body>

<div id="slider">
<div id="custom-handle" class="ui-slider-handle"></div>
</div>

<div class="demo-description">
<p>The basic slider is horizontal and has a single handle that can be moved with the mouse or by using the arrow keys.</p>
</div>
</body>
</html>
1 change: 1 addition & 0 deletions demos/slider/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<li><a href="range-vertical.html">Vertical range slider</a></li>
<li><a href="multiple-vertical.html">Multiple sliders</a></li>
<li><a href="colorpicker.html">Simple colorpicker</a></li>
<li><a href="custom-handle.html">Custom handle</a></li>
</ul>

</body>
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/slider/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ QUnit.test( "markup structure", function( assert ) {
assert.hasClasses( handle[ 1 ], "ui-slider-handle" );
} );

QUnit.test( "custom handle", function( assert ) {
assert.expect( 3 );

var element = $( "#slider-custom-handle" ).slider();
var customHandle = $( ".custom-handle" );
var sliderHandles = element.find( ".ui-slider-handle" );

assert.equal( sliderHandles.length, 1, "Only one handle" );
assert.strictEqual( sliderHandles[ 0 ], customHandle[ 0 ], "Correct handle" );
assert.equal( customHandle.attr( "tabIndex" ), 0, "tabIndex" );
} );

QUnit.test( "keydown HOME on handle sets value to min", function( assert ) {
assert.expect( 2 );
element = $( "<div></div>" );
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/slider/slider.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

<div id="slider1"></div>
<div id="slider2"></div>
<div id="slider3" style="position: relative; margin: 40px; width: 217px; height: 28px;">
<div class="ui-slider-handle" style="position: absolute; height: 21px; left: 0px; bottom: 0px; width: 17px;"></div>
<div id="slider-custom-handle">
<div class="ui-slider-handle custom-handle"></div>
</div>

</div>
Expand Down
4 changes: 3 additions & 1 deletion ui/widgets/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ return $.widget( "ui.slider", $.ui.mouse, {
this.handle = this.handles.eq( 0 );

this.handles.each( function( i ) {
$( this ).data( "ui-slider-handle-index", i );
$( this )
.data( "ui-slider-handle-index", i )
.attr( "tabIndex", 0 );
} );
},

Expand Down