Skip to content

Widget: Untrack classes elements when they are removed from the DOM #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Widget: Untrack classes elements when they are removed from the DOM #1744

wants to merge 3 commits into from

Conversation

arschmitz
Copy link
Member

Fixes #15043

scottgonzalez
scottgonzalez reviewed Sep 12, 2016
View reviewed changes
tests/unit/widget/classes.js
@@ -144,4 +146,34 @@ QUnit.test( "._add/_remove/_toggleClass()", function( assert ) {
elementLacksClasses( widget, "remove", assert );
} );

QUnit.test( "Classes elements are untracked as they are removed from the dom", function( assert ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dom -> DOM

scottgonzalez
scottgonzalez reviewed Sep 13, 2016
View reviewed changes
ui/widget.js
_untrackClassesElement: function( event ) {
var that = this;
$.each( that.classesElementLookup, function( key, value ) {
if ( $.inArray( event.target, that.classesElementLookup[ key ] ) !== -1 ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use value here.

@scottgonzalez
Copy link
Member

Looks good.

@arschmitz arschmitz closed this in 89af4c2 Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arschmitz @scottgonzalez @dmethvin @mgol @jquerybot