Skip to content

Widget: Avoid tracking remove event handlers for classes options#1769

Closed
scottgonzalez wants to merge 1 commit into
jquery:masterfrom
scottgonzalez:classes-remove-tracking
Closed

Widget: Avoid tracking remove event handlers for classes options#1769
scottgonzalez wants to merge 1 commit into
jquery:masterfrom
scottgonzalez:classes-remove-tracking

Conversation

@scottgonzalez
Copy link
Copy Markdown
Member

@scottgonzalez scottgonzalez commented Nov 16, 2016

Fixes #15082
Fixes #15095

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Nov 16, 2016 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@arschmitz
Copy link
Copy Markdown
Member

arschmitz commented Nov 16, 2016

👍

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Nov 16, 2016

Updated to avoid leaking event listeners.

@wangchangshan
Copy link
Copy Markdown

wangchangshan commented Jan 12, 2017

I also find this issue, thanks for your works ~~

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Apr 5, 2017

We might need to add a remove event listener to the element that is having classes added so that we untrack the element when it gets removed. This would catch scenarios like autocomplete menus having items created and destroyed constantly.

@scottgonzalez scottgonzalez force-pushed the classes-remove-tracking branch from 979e468 to e8767c9 Compare April 12, 2017 20:43
@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Apr 12, 2017

Updated to actually work. I confirmed that this fixes all reported issues with the remove event and have updated the commit message to reference all tickets.

@scottgonzalez
Widget: Improve remove event bindings for classes options
c87ee3b 
Fixes #15078
Fixes #15082
Fixes #15095
Fixes #15136
Fixes #15152
@scottgonzalez scottgonzalez force-pushed the classes-remove-tracking branch from e8767c9 to c87ee3b Compare April 17, 2017 20:45
arschmitz
arschmitz requested changes Apr 19, 2017
View reviewed changes
Comment thread ui/widget.js
var isTracked = $.map( that.classesElementLookup, function( elements ) {
return elements;
} )
.some( function( elements ) {
Copy link
Copy Markdown
Member

@arschmitz arschmitz Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a single element, so the name should be singular, though element is already taken

Copy link
Copy Markdown
Member Author

@scottgonzalez scottgonzalez Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a collection of elements for a single class.

@scottgonzalez scottgonzalez deleted the classes-remove-tracking branch April 19, 2017 16:54
scottgonzalez added a commit that referenced this pull request Apr 19, 2017
@scottgonzalez
Widget: Improve remove event bindings for classes options
ef2e9ba 
Fixes #15078
Fixes #15082
Fixes #15095
Fixes #15136
Fixes #15152
Closes gh-1769
@fnagel fnagel mentioned this pull request Jan 3, 2022
Merged
@mgol mgol mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arschmitz arschmitz arschmitz approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scottgonzalez @jsf-clabot @arschmitz @wangchangshan