Skip to content

[1.13] Dialog: Add icons option to support titlebar icons#1791

Open
scottgonzalez wants to merge 3 commits into
jquery:mainfrom
scottgonzalez:dialog-icon
Open

[1.13] Dialog: Add icons option to support titlebar icons#1791
scottgonzalez wants to merge 3 commits into
jquery:mainfrom
scottgonzalez:dialog-icon

Conversation

@scottgonzalez
Copy link
Copy Markdown
Member

@scottgonzalez scottgonzalez commented Jan 25, 2017

Still needs tests, but I wanted to make sure the team is good with adding this option.

See ticket 15121.

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Jan 25, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@jzaefferer
Copy link
Copy Markdown
Member

jzaefferer commented Jan 25, 2017

Seems good!

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Jan 29, 2017

Added tests.

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Jan 29, 2017

Note that I also changed the implementation because the original implementation didn't handle updating the icon after init.

@scottgonzalez scottgonzalez changed the title [WIP] Dialog: Add icons option to support titlebar icons Dialog: Add icons option to support titlebar icons Feb 1, 2017
@scottgonzalez scottgonzalez changed the title Dialog: Add icons option to support titlebar icons [1.13] Dialog: Add icons option to support titlebar icons Feb 1, 2017
@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Feb 1, 2017 •
edited
Loading

This PR now also removes the back compat for dialogClass. The deprecated tests were failing because I hadn't updated the options in common-deprecated.js. Since this can't land in 1.12 anyway, I figured I might as well just remove the back compat now.

jzaefferer
jzaefferer approved these changes Feb 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jzaefferer jzaefferer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could add a title icon to one of the demos, or at least to some of the visual tests for dialog.

Either way, this will wait for 1.12.2, right?

@scottgonzalez
Copy link
Copy Markdown
Member Author

scottgonzalez commented Feb 6, 2017

Yeah, this can't be released until 1.13.

Base automatically changed from master to main February 19, 2021 19:58
@nagyimre1980
Copy link
Copy Markdown

nagyimre1980 commented Oct 10, 2022 •
edited
Loading

For me this would be an important function. Could 1.13.3 be released? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jzaefferer jzaefferer jzaefferer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Comp: Dialog Feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scottgonzalez @jsf-clabot @jzaefferer @nagyimre1980 @fnagel