Menu: Handle mouse movement mixed with keyboard navigation #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
scottgonzalez
commented
Apr 18, 2017
| @@ -78,6 +78,8 @@ return $.widget( "ui.menu", { | |||
| // them (focus should always stay on UL during navigation). | |||
| "mousedown .ui-menu-item": function( event ) { | |||
| event.preventDefault(); | |||
|
|
|||
| this._activateItem( event ); | |||
There was a problem hiding this comment.
We activate on mousedown to handle the scenario of moving the mouse over an item, navigating away from that item with they keyboard, then clicking with the mouse. Since we won't get a mouseenter or mousemove, we need to activate on mousedown. This matches the OS X menu behavior.
| @@ -107,29 +109,8 @@ return $.widget( "ui.menu", { | |||
| } | |||
| } | |||
| }, | |||
| "mouseenter .ui-menu-item": function( event ) { | |||
There was a problem hiding this comment.
This method was moved to _activateItem().
| // If the item is already active, there's nothing to do | ||
| if ( target.is( ".ui-state-active" ) ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This conditional is the only thing that changed in this method. This is just the avoid the expensive work that follows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9357