Menu: Close menus immediately on selection or click outside #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
scottgonzalez
commented
Apr 18, 2017
| assert.equal( logOutput(), "keydown,3,4,7", "Keydown focus skips divider and group label" ); | ||
| element.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } ); | ||
| element.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } ); | ||
| assert.equal( logOutput(), "keydown,1,2,3,4,7", "Keydown focus skips divider and group label" ); |
There was a problem hiding this comment.
This test changed because an item is selected in the step before this, causing the menu to close. This test only passed before because of the short delay; had it waited for the menu to fully react, the test would have failed.
jzaefferer
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15034