Skip to content

Button: Fix backcompat when called on collection of mixed elements #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Button: Fix backcompat when called on collection of mixed elements #1808

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bed3d7f
Button: Fix backcompat when called on collection of mixed elements
arschmitz Apr 19, 2017
14e8ff7
Button: uncomment test
arschmitz Apr 19, 2017
8288f5d
Button: fixup
arschmitz Apr 19, 2017
46b04f7
button: fixup
arschmitz Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Button: fixup
  • Loading branch information
@arschmitz
arschmitz committed Apr 19, 2017
commit 8288f5deadeba3a5a62216a0477ffdbe5aef883f
6 changes: 3 additions & 3 deletions tests/unit/button/deprecated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@ QUnit.test( "icon / icons options properly proxied", function( assert ) {
QUnit.test("Calling button on a collection of mixed types works correctly", function(assert) {
assert.expect(5);

var group = $(".mixed").children()
var group = $(".mixed").children();

group.button()
group.button();

$.each( {
anchor: "button",
Expand All @@ -210,6 +210,6 @@ QUnit.test("Calling button on a collection of mixed types works correctly", func
}, function (type, widget) {
assert.ok($("#mixed-" + type)[widget]("instance"), type + " is a " + widget);
} );
})
});

} );