Skip to content

Draggable: Use relative coordinates for snapElements #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Draggable: Use relative coordinates for snapElements #1835

wants to merge 1 commit into from

Conversation

uunicorn
Copy link

Since scrolling position may change while dragging, so are the absolute
coordinates of the snapElements.

Fixes #14694

@jsf-clabot
Copy link

jsf-clabot commented Sep 20, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@uunicorn
Draggable: Use relative coordinates for snapElements
b1e959b 
Since scrolling position may change while dragging, so is the absolute
coordinates of the snapElements.

Fixes #14694
@uunicorn uunicorn force-pushed the 14694-broken-snap-on-scroll branch from 227b213 to b1e959b Compare September 20, 2017 06:07
@dmethvin
Copy link
Member

dmethvin commented Aug 1, 2019

Is there a way to test this?

Base automatically changed from master to main February 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Comp: Draggable Needs tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uunicorn @jsf-clabot @dmethvin @fnagel