Effects: Split, new effect

[jstroem]

The split effects reported in feature bug http://bugs.jqueryui.com/ticket/7069 has been implemented

[gnarf]

Awesome work here @Lindstroem! So, this brings up one bit of conversation - This effect set totally includes (and supersedes) the current effects.explode - I'm thinking we might want to replace the current explode effect with yours...

[gnarf]

Since this doesn't really do anything "visual" do you think you could clear it out of this test? If its not working, the next 4 effects aren't going to work either...

[gnarf]

Also, I just got called out on some of my code for jquery.color -- We should always prefer using double quotes instead of single quotes, as well as === instead of == ( unless we really want the == )

[gnarf]

Having just seen the above 20 lines of code duplicated, might it be possible to create a function to DRY this up a little?

function splitOptions( el, defaults, o ) {
   var opt = $.extend( {}, defaults, o );
   if ( el.is( ':hidden' ) && opt.mode === "toggle") {
     opt.reverse = !opt.reverse;
   }
   opt.mode = $.effects.setMode( el, opt.mode );
   opt.show = opt.mode === "show";
   return opt;
 }

 // then in the functions:
 var el = $( this ),
     opt = splitOptions( el, {.....}, o );

[jstroem]

What if a element is trying to split out of the document like, moves to a negative value or larger than the document is wide/high?

Should this be taken care of maybe?

[gnarf]

I would think it may be possible to wrap the container element in an overflow:hidden that is document width/height so that the animations can go outside the doc all they want but not induce extra scrollbars

[gnarf]

This pull has gone stale, any chance we can get it freshened up?

[jstroem]

so there is really 2 things to this pull the first is the split thing just on normal elements and, as far as i know, there is nothing more to put into this? it works right?

then there is the effects on the text witch i have made some of but as i remember have some problems with. So i will write this on my todo list and i should have time se whats needed!

[jstroem]

ohh.. just looked at the repo..
this is only a pull on the split things on the html elements not the text split?

I think i stopped working on the text split effects because there were some guys (on weekly dev meetings) that said this split wasn't going to get under the hood of jquery ui?

but i don't know if that has changed now where 2.0 is a little closer?

[gnarf]

We can look again at the text split, but I still think this could use some freshening up... I'd like to see the split effects land in 1.9, but It no longer merges cleanly with master, and I believe its still using an API that isn't current in 1.9... track me down, talk with me about it :)

[jstroem]

i just gonna take a quick look at the code tomorrow and then i will catch you at irc and we can discuss whats need to be done!

[paulirish]

@Lindstroem can you summarize what the status is? I'd love to see this make its way in and can ask Scott to take a look..

[gnarf]

I'm still willing to update this branch myself if @Lindstroem doesn't have the time for it

[jstroem]

Yea. so I've been looking into it today and it is good to go.. but the merging with master fails as i understand from @gnarf37.. so if there is something there needs to be updated in the code just notifiy me!

[paulirish]

lindstroem can you reopen ;)

[jstroem]

@gnarf37: any news on this?

[Jellyfrog]

Bump

[paulirish]

👍

[sindresorhus]

👍

[jstroem]

been looking into this; in the pull request status: http://oksoclap.com/ui-pull-requests the following is pointed out:

#185 - Split

• on hold, waiting for a big block of time to review new set of effects
• would rather get existing code cleaned up first

i don't know if anyone is up for reviewing and how the status is for the other cleaning tasks. I will try to be at the weekly meeting for UI today and ask into this.

[gnarf]

We haven't used that clap in a while, but that was the last time we did a big group review of pulls.

I do want this to land in 1.9 soon, but I'm pretty involved in some other areas of the project right now that stop me from doing the necessary work at the current moment.

[mikesherov]

@gnarf37, @scottgonzalez, @jzaefferer ping.

[scottgonzalez]

We're still waiting until we've cleaned up more of the existing code before adding more effects.

[mikesherov]

Thanks again for the had work here, but we've finally decided that we're not going to pursue further effects at this time, and therefore, are closing this pull request.