Build: Update to the latest version of Grunt & many other packages #1882
Conversation
|
|
|
In this configuration I was able to update grunt to the latest version and have it still process & test the files without failure. I would recommend migrating away from jscs to eslint as the jscs team has been working with eslint for some time (please see the node-jscs repo, their Medium article and user guide for migrating to eslint). However, that being said, I've attempted this locally, and the tests resulted in failure because of syntax errors (mainly with spacing) which I believe may be related to the jquery eslint rule set. In addition, there was some CSS & HTML syntax rule issues when I upgraded grunt-contrib-csslint and grunt-html to latest. I can upgrade these as well, however that would mean addressing the syntax issue(s) as well. If that's not an issue, I can proceed with that as well. |
|
Just saw the Travis CI result which is what I was seeing when I updated grunt-jscs. It worked for me locally, but that may have been a fluke as I was upgrading/downgrading npm packages. Should I address the syntax warnings as well? |
|
@Mikhey Thanks, and sorry for the long delay! I agree we'd like to move to eslint, are you interested in doing that? Just the upgrade to the latest grunt will help. |
|
My apologies for not getting back to you sooner! I would love to help out with that! |
1f0b500 to
e50f272
Compare
JSHint, JSCS & QUnit-related packages are not updated as they need more code adjustments. Closes gh-15112
e50f272 to
fc44dc1
Compare
JSHint, JSCS & QUnit-related packages are not updated as they need more code adjustments. Fixes #15112 Closes gh-1882
|
I updated a few more packages & landed the PR in a22361d. Thanks! |
|
@Mikhey Are you still interested in trying to migrate us to ESLint? We'd use |
Closes trac-15112