Skip to content

Position - Fix #7211 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jfremy wants to merge 4 commits into from
Closed

Position - Fix #7211 #189

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7e00cc
Check if we are too far left / down as well as right / bottom - Fix #…
Apr 23, 2011
401962d
Improved fix. When element does not fit, set it to top / left border …
Apr 25, 2011
1db56e4
Last commit deleted one line too many
Apr 25, 2011
c71d898
Factorized first two tests
Apr 25, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 36 additions & 9 deletions ui/jquery.ui.position.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,20 +184,47 @@ $.ui.position = {
fit: {
left: function( position, data ) {
var win = $( window ),
over = data.collisionPosition.left + data.collisionWidth - win.width() - win.scrollLeft();
position.left = over > 0 ?
position.left - over :
Math.max( position.left - data.collisionPosition.left, position.left );
overLeft = win.scrollLeft() - data.collisionPosition.left,
overRight = data.collisionPosition.left + data.collisionWidth - win.width() - win.scrollLeft();
/*
Cases considered:
1) element width does not fit. Left align on left border of screen
2) element is too far left, bring back on left side of screen
3) element is too far right, bring back on right side of the screen
4) set element accordingly while making sure it's more than leftMargin from the left border of the document
*/

if( data.collisionWidth > win.width() || overLeft > 0 ) {
position.left = position.left + overLeft;
} else if( overRight > 0) {
position.left = position.left - overRight;
} else {
position.left = Math.max( position.left - data.collisionPosition.left, position.left );
}
},
top: function( position, data ) {
var win = $( window ),
over = data.collisionPosition.top + data.collisionHeight - win.height() - win.scrollTop();
position.top = over > 0 ?
position.top - over :
Math.max( position.top - data.collisionPosition.top, position.top );
overTop = win.scrollTop() - data.collisionPosition.top,
overBottom = data.collisionPosition.top + data.collisionHeight - win.height() - win.scrollTop();

/*
Cases considered:
1) element height does not fit. Top align on top border of screen
2) element is too far up, bring back on top of screen
3) element is too far down, bring back on bottom of the screen
4) set element accordingly while making sure it's more than topMargin from the top of the document
*/

if( data.collisionHeight > win.height() || overTop > 0 ) {
position.top = position.top + overTop;
} else if(overBottom > 0) {
position.top = position.top - overBottom;
} else {
position.top = Math.max( position.top - data.collisionPosition.top, position.top );
}
}
},

},
flip: {
left: function( position, data ) {
if ( data.at[ 0 ] === center ) {
Expand Down