Skip to content

Build: Update grunt-contrib-qunit version from 1.0.1 to 4.0.0 #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

sakshisharmapuresoftware
Copy link
Contributor

Updated grunt-contrib-qunit version to 3.1.0 to provide puppeteer support as the older version was using phantomjs.

Updated Gruntfile with puppeteer configuration as well.

@jsf-clabot
Copy link

jsf-clabot commented Aug 7, 2019

CLA assistant check
All committers have signed the CLA.

@sakshisharmapuresoftware
Copy link
Contributor Author

@mgol I modified the file as per your suggestions, please do revert if something else needs to be done from my end.

@sakshisharmapuresoftware
Copy link
Contributor Author

@mgol Updated grunt-contrib-qunit to latest in package.json as the latest version
has support for aarch64 platform. Updated travis.yml to use latest nodejs versions as puppeteer doesn't support older versions.

@mgol
Copy link
Member

mgol commented Oct 20, 2020

@sakshi87 can you rebase? Changes in the Travis config should no longer be needed.

Signed-off-by: sakshi87 <sakshi.sharma@puresoftware.com>
@mgol
Copy link
Member

mgol commented Oct 21, 2020

Thank you!

@mgol mgol added this to the 1.13 milestone Oct 21, 2020
@mgol mgol self-assigned this Oct 21, 2020
@mgol mgol changed the title jquery-ui: Updated grunt-contrib-qunit version Build: Update grunt-contrib-qunit version from 1.0.1 to 4.0.0 Oct 21, 2020
@mgol mgol merged commit 91b6fc3 into jquery:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants