Skip to content

Build: Update grunt-contrib-qunit version from 1.0.1 to 4.0.0#1894

Merged
mgol merged 4 commits into
jquery:masterfrom
sakshisharmapuresoftware:jquery_ui
Oct 21, 2020
Merged

Build: Update grunt-contrib-qunit version from 1.0.1 to 4.0.0#1894
mgol merged 4 commits into
jquery:masterfrom
sakshisharmapuresoftware:jquery_ui

Conversation

@sakshisharmapuresoftware
Copy link
Copy Markdown
Contributor

Updated grunt-contrib-qunit version to 3.1.0 to provide puppeteer support as the older version was using phantomjs.

Updated Gruntfile with puppeteer configuration as well.

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Aug 7, 2019

CLA assistant check
All committers have signed the CLA.

Comment thread Gruntfile.js Outdated
Comment thread Gruntfile.js Outdated
@sakshisharmapuresoftware
Copy link
Copy Markdown
Contributor Author

@mgol I modified the file as per your suggestions, please do revert if something else needs to be done from my end.

@sakshisharmapuresoftware
Copy link
Copy Markdown
Contributor Author

@mgol Updated grunt-contrib-qunit to latest in package.json as the latest version
has support for aarch64 platform. Updated travis.yml to use latest nodejs versions as puppeteer doesn't support older versions.

@mgol
Copy link
Copy Markdown
Member

mgol commented Oct 20, 2020

@sakshi87 can you rebase? Changes in the Travis config should no longer be needed.

Signed-off-by: sakshi87 <sakshi.sharma@puresoftware.com>
@mgol
Copy link
Copy Markdown
Member

mgol commented Oct 21, 2020

Thank you!

Comment thread Gruntfile.js Outdated
Comment thread Gruntfile.js Outdated
Comment thread Gruntfile.js Outdated
@mgol mgol added this to the 1.13 milestone Oct 21, 2020
@mgol mgol self-assigned this Oct 21, 2020
@mgol mgol changed the title jquery-ui: Updated grunt-contrib-qunit version Build: Update grunt-contrib-qunit version from 1.0.1 to 4.0.0 Oct 21, 2020
@mgol mgol merged commit 91b6fc3 into jquery:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants