Remove IE8 support that crashes in some cases (in my case using Drupa…#1897
Remove IE8 support that crashes in some cases (in my case using Drupa…#1897joejoseph00 wants to merge 1 commit into
Conversation
…l and the views_load_more module in combination with jQuery UI 12.1
|
Yay, passing! |
|
I set the milestone to 1.14.0 it as we agreed not to remove IE 8 workarounds from 1.13 yet. If you'd like to land it sooner, we'd need a way to have the patch apply only when needed. However, the existing check already tries to achieve exactly that... So it'd be good to get more details about the crash: what exactly causes the crash, in which browsers, etc. |
|
@mgol might as well wait for 1.14.0 . with that said, IE8 is basically kaput for all intents and purposes. The only people running it would be those not connected to the internet and they'd probably not be changing versions of jQuery. |
|
|
|
I signed all the approvals now |
|
Sure, no problem. Take note, though, that we've released 1.13.0 not so long ago so I wouldn't expect 1.14.0 to arrive any time soon. We want to let it stay on 1.13.0 for a while, let folks update, discover & fix regressions from 1.12.1, etc. |
|
We'll be dropping all IE versions in 1.14.0 in a much larger PR. A part of it will be removing the Thanks for your contribution anyway! |
Remove useless IE8 support (causes problems in some use cases, particularly when using jQuery ui with the Drupal contrib module named "views_load_more" module.
History is here: #1893
…l and the views_load_more module in combination with jQuery UI 12.1