Skip to content

Tests: Ensure no timers are running at the end of each test #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 4 commits into from
May 16, 2020
Merged

Tests: Ensure no timers are running at the end of each test #1920

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f183af4
Tests: Ensure no timers are running at the end of each test
mgol May 13, 2020
dd25699
Tests: Rename legacy setup/teardown hooks to beforeEach/afterEach
mgol May 13, 2020
97720a5
Tests: Ensure no timers are running at the end of each test
mgol May 13, 2020
a6271df
Tests: Add a tooltip test helper cleaning up leftover timers
mgol May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tests: Rename legacy setup/teardown hooks to beforeEach/afterEach
  • Loading branch information
@mgol
mgol committed May 16, 2020
commit dd25699969e24a782a71f029e55d66b25521a446
4 changes: 2 additions & 2 deletions tests/unit/controlgroup/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,12 @@ QUnit.test( "Single controlgroup button - vertical", function( assert ) {
} );

QUnit.module( "Controlgroup: Non-empty class key", {
setup: function() {
beforeEach: function() {
this.classKey = $.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ];
$.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ] =
"something-custom";
},
teardown: function() {
afterEach: function() {
$.ui.selectmenu.prototype.options.classes[ "ui-selectmenu-button-closed" ] = this.classKey;
}
} );
Expand Down