Tests: Account for extra focus/blur listeners in jQuery >=3.4#1930
Merged
Conversation
jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various issues with checkboxes/radio buttons as well as being able to pass data in focus triggers. However, this leaves dummy focus & blur events if any of these events were ever listened to at a particular element. There's not a lot UI can do to fix this so we now just skip these handlers for data comparisons in tests. Ref jquery/jquery#4496
timmywil
approved these changes
Jun 29, 2020
Member
timmywil
left a comment
There was a problem hiding this comment.
LGTM. A little hacky, but should be future safe.
gibson042
approved these changes
Jun 29, 2020
Member
gibson042
left a comment
There was a problem hiding this comment.
This fix fails to filter out the dummy handlers added when .trigger precedes .on, but that would only be a problem if such cases exist in the test suite. Apparently they don't, so this works! 👍
| // a lot UI can do to fix this so just skip these handlers for | ||
| // data comparisons in tests. | ||
| // See https://github.com/jquery/jquery/issues/4496 | ||
| if ( result.events && jQueryVersionSince( "3.4.0" ) ) { |
Member
There was a problem hiding this comment.
Do we actually need to restrict this code to jQuery >= 3.4.0? What would happen without the check?
Member
Author
There was a problem hiding this comment.
I thought since this excludes some things from the compared objects, in older jQueries where there are no additional listeners we could perform a full check. There's always a risk that the workaround will not account for some real differences and by restricting it to jQuery >=3.4.0 we'd see a test error in older jQuery versions in such a case.
UI is currently tested with Core >=1.8.
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
melloware
approved these changes
Jul 2, 2020
arschmitz
approved these changes
Jul 23, 2020
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
Feb 19, 2021
jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various issues with checkboxes/radio buttons as well as being able to pass data in focus triggers. This leaves extra focus & blur events if any of these events were ever listened to at a particular element. We've started skipping these handlers in the `domEqual` assertion in jquerygh-1930 but we missed a case where an event is triggered before any handler is attached - jQuery >=3.4.0 attaches then an extra noop listener just to force the code path to go through the setup code before the trigger happens. We now skip this extra handler as well. This fixes a test failure in "dialog: methods" destroy tests. Ref jquery/jquery#4496 Ref jquerygh-1930
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
Feb 19, 2021
jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various issues with checkboxes/radio buttons as well as being able to pass data in focus triggers. This leaves extra focus & blur events if any of these events were ever listened to at a particular element. We've started skipping these handlers in the `domEqual` assertion in jquerygh-1930 but we missed a case where an event is triggered before any handler is attached - jQuery >=3.4.0 attaches then an extra noop listener just to force the code path to go through the setup code before the trigger happens. We now skip this extra handler as well. This fixes a test failure in "dialog: methods" destroy tests. Ref jquery/jquery#4496 Ref jquerygh-1930
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
Feb 19, 2021
jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various issues with checkboxes/radio buttons as well as being able to pass data in focus triggers. This leaves extra focus & blur events if any of these events were ever listened to at a particular element. We've started skipping these handlers in the `domEqual` assertion in jquerygh-1930 but we missed a case where an event is triggered before any handler is attached - jQuery >=3.4.0 attaches then an extra noop listener just to force the code path to go through the setup code before the trigger happens. We now skip this extra handler as well. This fixes a test failure in "dialog: methods" destroy tests. Ref jquery/jquery#4496 Ref jquerygh-1930
mgol
added a commit
that referenced
this pull request
Feb 20, 2021
jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various issues with checkboxes/radio buttons as well as being able to pass data in focus triggers. This leaves extra focus & blur events if any of these events were ever listened to at a particular element. We've started skipping these handlers in the `domEqual` assertion in gh-1930 but we missed a case where an event is triggered before any handler is attached - jQuery >=3.4.0 attaches then an extra noop listener just to force the code path to go through the setup code before the trigger happens. We now skip this extra handler as well. This fixes a test failure in "dialog: methods" destroy tests. Closes gh-1945 Ref jquery/jquery#4496 Ref gh-1930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery >=3.4.0 uses a special focus/blur handler pair
needed to fix various issues with checkboxes/radio buttons
as well as being able to pass data in focus triggers.
However, this leaves dummy focus & blur events if any of these
events were ever listened to at a particular element. There's not
a lot UI can do to fix this so we now just skip these handlers for
data comparisons in tests.
Ref jquery/jquery#4496