Core: Resolve csslint issues with the IE filter property #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE filter property violates standard CSS parsing rules. Because of that, IE 8 added `-ms-filter` which accepts the same values but quoted: https://web.archive.org/web/20101112132308/http://blogs.msdn.com/b/ie/archive/2008/09/08/microsoft-css-vendor-extensions.aspx Both `filter` & `-ms-filter` serialize to the same `filter` property in `currentStyle`. This commit switches to that new property to resolve csslint issues.
fnagel
approved these changes
Oct 15, 2020
|
@dharitdesai There's no concrete release date, we need to fix all the tests & make a few other changes, then prepare a blog post & do a release. I cannot predict when exactly I'll have time to work on the remaining pieces or how long they'll take. That said, I feel we're closer to the end than to the beginning when I started submitting these patches (which was a bit more than a year ago). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE filter property violates standard CSS parsing rules. Because of that, IE 8
added
-ms-filterwhich accepts the same values but quoted:https://web.archive.org/web/20101112132308/http://blogs.msdn.com/b/ie/archive/2008/09/08/microsoft-css-vendor-extensions.aspx
Both
filter&-ms-filterserialize to the samefilterproperty incurrentStyle.This commit switches to that new property to resolve csslint issues.